Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality problem #374

Closed
Feuerhamster opened this issue Oct 26, 2018 · 3 comments
Closed

Quality problem #374

Feuerhamster opened this issue Oct 26, 2018 · 3 comments
Labels

Comments

@Feuerhamster
Copy link

Feuerhamster commented Oct 26, 2018

Hello.

Im using the latest version of ytdl-core.
If i download a video with {quality:"highest",filter:"audioandvideo"}, i get a video with sound, but in worst video quality.
If i download a video with {quality:"highestvideo",filter:"audioandvideo"}, i get a video with sound, but in worst video quality.
If i download a video with {quality:"highestvideo"}, i get a video with no sound, but in very good quality.

Thats bad because i would like to download the video with audio in high quality.

Greetings,
Feuerhamster

@TimeForANinja
Copy link
Collaborator

Hey,
the problem is that YouTube does only server video & audio up to 420p, after that you have to manually pack audio and video together in a container using sth like ffmpeg (only takes seconds if u do it right).

regards
TimeForANinja

@Feuerhamster
Copy link
Author

Oh ok. That sounds complicated, because i dont know how download video & audio seperated and use ffmpeg.
I'm surprised, because a few month ago, the same module downloaded it with high video and audio quality.

@fent
Copy link
Owner

fent commented Oct 27, 2018

There's an example on how to use ffmpeg to do this
https://github.com/fent/node-ytdl-core/blob/master/example/ffmpeg.js

Doing this ourselves in this module, would mean including ffmpeg in the codebase. Which some may not agree with as it goes against the pure js approach of this library, makes it less portable, and increases dependency filesize.

I have been considering creating an additional library that would do this and other common questions we get like downloading playlists.

@fent fent closed this as completed Oct 27, 2018
@fent fent added the question label Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants