-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use more reliable json endpoint #605
Conversation
i now feel like my original |
thats smart |
lib/info-extras.js
Outdated
// Do nothing. | ||
} | ||
let v = results.find(v2 => | ||
v2.videoSecondaryInfoRenderer && v.videoSecondaryInfoRenderer.owner); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a typo here, it should be v2.videoSecondaryInfoRenderer.owner
instead of v.videoSecondaryInfoRenderer.owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
fixes #523
fixes #495
still need to update tests
(also opening this to test the eslint job on PRs)