Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing related songs #800

Closed
skick1234 opened this issue Dec 1, 2020 · 3 comments
Closed

Missing related songs #800

skick1234 opened this issue Dec 1, 2020 · 3 comments
Labels

Comments

@skick1234
Copy link
Contributor

skick1234 commented Dec 1, 2020

let info = await pipeline([id, options], retryOptions, isValid, [
getJSONWatchPage,
getEmbedPage,
getVideoInfoPage,
]);

I think we should use getVideoInfoPage instead of getEmbedPage.
Because an embed page doesn't provide any related songs and on browser, it has to use getVideoInfoPage to get related videos at the end of a video. Some other properties such as like, dislike is null too

@fent fent added the bug label Dec 2, 2020
@fent
Copy link
Owner

fent commented Dec 2, 2020

yep, embed was mainly used to get around age restricted content while not logged in. but that no longer works.

I'm also thinking of adding the regular watch.html page as backup, it has related video content too

@skick1234
Copy link
Contributor Author

I'm also thinking of adding the regular watch.html page as backup, it has related video content too

And you can update the client version automatically with this. It contains INNERTUBE_CLIENT_VERSION

@fent fent closed this as completed in fc3025d Dec 7, 2020
@fent
Copy link
Owner

fent commented Dec 7, 2020

And you can update the client version automatically with this. It contains INNERTUBE_CLIENT_VERSION

right now the json endpoint is tried first, then the watch.html endpoint. the json endpoint hasn't been very reliable though, except with cookies i hear, so we could switch their position and then grab the client version in case the watch.html endpoint fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants