Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use weak timeout (rather than strong timeout) #821

Merged
merged 2 commits into from Dec 13, 2020
Merged

Conversation

coolaj86
Copy link
Contributor

As per https://nodejs.org/api/timers.html#timers_timeout_unref, calling .unref() will mark the timer as weak in the event loop and then return the timeout object.

Fixes #819.

@fent
Copy link
Owner

fent commented Dec 12, 2020

cool! i wasn't aware of this API on timeouts, pretty handy.

one request, do you mind removing the process.exit() line from example/ffmpeg.js. it's only there because of the timeouts hanging.

@coolaj86
Copy link
Contributor Author

@fent Done.

@fent
Copy link
Owner

fent commented Dec 13, 2020

thanks!

@fent fent merged commit e7ad270 into fent:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream doesn't end when video is done downloading
2 participants