Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storyboards to info.videoDetails #851

Merged
merged 5 commits into from Jan 3, 2021
Merged

Conversation

Aasim-A
Copy link
Contributor

@Aasim-A Aasim-A commented Jan 1, 2021

The storyboards spec field has the information of the available storyboards encoded inside.

Copy link
Owner

@fent fent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're on a roll 👍

i'm not familiar with youtube storyboards. what do they represent? is it the cards that pop up near the end of videos or something else? could you provide an example video that has them?

test/info-extras-test.js Outdated Show resolved Hide resolved
@Aasim-A
Copy link
Contributor Author

Aasim-A commented Jan 1, 2021

Sure, the storyboard is a preview for the video represented as pictures, you see them above the seeking bar when seeking the video.

Youtube storyboard

Video source: Tim Ermilov

@Aasim-A Aasim-A requested a review from fent January 2, 2021 03:06
lib/info-extras.js Outdated Show resolved Hide resolved
lib/info-extras.js Show resolved Hide resolved
lib/info-extras.js Show resolved Hide resolved
@Aasim-A Aasim-A requested a review from fent January 3, 2021 02:10
Copy link
Owner

@fent fent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks again for taking the time in figuring out how this works and filing a PR 🎉

@fent fent changed the title Add storyboards to info.videoInfo Add storyboards to info.videoDetails Jan 3, 2021
@Aasim-A
Copy link
Contributor Author

Aasim-A commented Jan 3, 2021

No worries! 🙂

@fent fent merged commit 9aa5c55 into fent:master Jan 3, 2021
@github-actions
Copy link

github-actions bot commented Jan 3, 2021

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Aasim-A Aasim-A deleted the pr/add-storyboard branch January 3, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants