New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty related videos when able to choose the topic of related videos #853
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, thanks for another PR
how did you generate the watch.html
page with autoplay on? is that something that can be turned by a cookie or user setting? i'd like to add it to test/files/refresh.js
in case it needs to be updated in the future
Actually, this is not because the autoplay feature is on. When I logged in, related videos can be sort (e.g. All, Cats, Recently Uploaded). This makes related videos empty. I tried to remove all the account-login cookies (keep PREF, ... cookies) but I cannot reproduce that. Maybe this is a user-only feature or a beta feature, idk. EDIT: This is Up Next Topics feature I think |
hmm, so the saved html and json pages can't be added to |
I'm afraid that can't be done without an user cookie.
I logged from miniget response with my clone's cookie. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still think related-topics
should be added to refresh.js
, only for future maintenance. just add a note that it needs a requestOptions: { headers: 'YOUR_COOKIE' }
.
btw, the watch.html
file contains possibly identifying values from the account you used, things like ID_TOKEN
and INNERTUBE_API_TOKEN
. i'm actually not sure how compromising these are, but could be worth removing them if you have concerns. or maybe you used a throwaway account and it doesn't matter
I used my clone account to run Maybe we should add a cookie to environment variables. Or just update it manually :> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
🎉 This PR is included in version 4.4.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fix empty related videos when the watch page contains autoplay feature
It happens in some regions or when using cookies.
closes #810
closes #848