Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Contributions objects from the feos.pcsaft module #80

Closed
defencedog opened this issue Nov 27, 2022 · 4 comments
Closed

Missing Contributions objects from the feos.pcsaft module #80

defencedog opened this issue Nov 27, 2022 · 4 comments

Comments

@defencedog
Copy link

Cannot run this notebook because of above error pcsaft_phase_diagram.ipynb

@g-bauer
Copy link
Contributor

g-bauer commented Nov 27, 2022

Hey, thanks for trying out FeOs. You are right, the text above the input statements is out of date. The Contributions object can be imported from the feos.eos module, i.e. from feos.eos import Contributions should do the trick. I will update the documentation.

In the notebook, however, we use from feos.eos import *. You should be able to run the whole notebook as is. Are you using this notebook?

@defencedog
Copy link
Author

@g-bauer extremely thanks. Will you be updating notebooks in git as per latest API ...it means a lot for new users

@g-bauer
Copy link
Contributor

g-bauer commented Nov 27, 2022

I will fix the text. Does the notebook work properly? On my machine with the latest version of FeOs it does. Also, you can always check the Python API here. And this is the link to the feos.eos module where the Contributions object is exported.

@defencedog
Copy link
Author

@g-bauer Yes it works properly. Extremely thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants