Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 2D images #22

Closed
fepegar opened this issue Jan 6, 2020 · 4 comments · Fixed by #163
Closed

Add support for 2D images #22

fepegar opened this issue Jan 6, 2020 · 4 comments · Fixed by #163
Labels
enhancement New feature or request

Comments

@fepegar
Copy link
Owner

fepegar commented Jan 6, 2020

No description provided.

@deepnarainsingh
Copy link

Hi @fepegar ,

Great work , could you please provide the details for this requirement , would like to contribute.

@fepegar
Copy link
Owner Author

fepegar commented Jan 6, 2020

Hi @deepnarainsingh,

Thanks for your interest!

I suppose there are multiple issues about this:

  1. Adapting the io module to read and write common 2D formats such as JPEG or PNG
  2. Thinking whether 2D images should be treated as 3D images with depth 1 or actually remove dimension
  3. Make sure all transforms work as expected for 2D inputs

You can start by forking the repo, adding a branch named 22-add-2d-support, create a temporary pull request to the master branch of this repo and start committing.

@fepegar fepegar added the enhancement New feature or request label Jan 6, 2020
@deepnarainsingh
Copy link

Thanks for the details @fepegar .
I will go through the code and check .

@fepegar fepegar self-assigned this Jan 14, 2020
@fepegar
Copy link
Owner Author

fepegar commented Jan 14, 2020

@deepnarainsingh What would be your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants