Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result dismatch with paper #81

Closed
monkdou0 opened this issue Jan 12, 2021 · 7 comments
Closed

result dismatch with paper #81

monkdou0 opened this issue Jan 12, 2021 · 7 comments

Comments

@monkdou0
Copy link

the result of SARI and bleu to model is mismatch with the original paper
WHY?????
image

image

@louismartin
Copy link
Collaborator

Hello @monkdou0
Thanks for the issue.
As mentioned in the the last section of the README, the EASSE implementation fixes bugs and inconsistencies with previous versions of SARI that were used in earlier works.
The scores are not the same although similar.
We highly recommend to use this fixed version and recompute scores using the system outputs provided in the library.

@louismartin
Copy link
Collaborator

louismartin commented Jan 12, 2021

If you use the latest version of EASSE, you will get these results:

$ easse evaluate -t turkcorpus_test -m sari,bleu -i easse/resources/data/system_outputs/turkcorpus/test/Hybrid
{'bleu': 50.707, 'sari': 31.497}

Papers which use the latest version of SARI include: Multilingual Unsupervised Sentence Simplification.

@monkdou0
Copy link
Author

my version is 580bba7,
and the result is
➜ easse evaluate -t turkcorpus_test -m sari,bleu -i easse/resources/data/system_outputs/turkcorpus/test/Hybrid
{'bleu': 50.707, 'sari': 28.154}

@monkdou0
Copy link
Author

I have find what's wrong with me
THx! @louismartin

@louismartin
Copy link
Collaborator

Hi @monkdou0 do you mind sharing what was wrong with us?
It might help other people in the future!

@monkdou0
Copy link
Author

That is totally my own fault.
i change the code of the implementation of SARI function several days ago, and compile it today.
This repo is useful for the task of text simplification.
Very good! thx

@louismartin
Copy link
Collaborator

Ok thanks, closing the issue then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants