-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated barrelfile incomplete #264
Comments
Hi Pieter, let me check, I'll add some additional test cases for these scenarios. |
Great! I'm currently seeing if I can make a PR to fix this. |
Weird thing is that if I look at your code, it seems valid to me, yet with even version 0.4.4 I see the behaviour is wrong. |
@PieterVanEde Can you share you spec with me? Is that possible? |
Or the better question: if you generate it with the default options, does everything look good then? |
Yep, after fooling around a bit, I've found the following:
|
Ah maybe the parsing logic of the booleans are wrong somehow, are using the Node API or using it via command line / package json? |
The parsing is indeed wrong, I've linked my local checkout of my fork inside my test project, and added this to the top of the index.hbs:
Result for config |
I'm using the typescript interface to call the library |
Strangely enough, only the barrel file is wrong. The actual files that are output, are correct. |
Error spotted, PR on its way |
I don't have the time to write some tests, could I leave that to you? |
PR is created, hope you agree ;) |
Cool, thanks for spotting this, stupid mistake, will push a new version to npm now |
Pushed 0.4.5 |
I re-opend this as a reminder to add some test cases |
Great! And well, there is a stupid mistake in a great library that I could use for free, so I don't see a problem ;) |
When I generate using these options:
exportCore: false, exportModels: true, exportSchemas: true, exportServices: false,
Then the barrel file has the following problems:
The text was updated successfully, but these errors were encountered: