Fixed CVE-2020-16845 by upgrading xz #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this one @naveensrinivasan. Looks like there's a failing test because the go.sum doesn't match up? Try running a Thanks |
I already did that . I also downloaded Thanks Would you mind pulling down the branch running tidy? |
|
Hey @naveensrinivasan can confirm running go mod tidy actually updates 3 of the You can check the logic required to pass the tests here: Thanks |
If you don't mind would you be able to push that commit with I feel that the Thanks |
|
@naveensrinivasan unfortunately that branch is on your forked repository so I can't push anything to it. I recommend running GoLang 1.13 using docker as so |
Upgraded xz to fix this CVE GHSA-25xm-hr59-7c27
Included the replace directives to avoid including the CVE dependency.
naveensrinivasan
force-pushed
the
naveen/feat/fix-cve
branch
from
aabb5c0
to
28880f8
Compare
Thanks, I have pushed the changes. Appreciate the detailed instructions 👍 |
|
@naveensrinivasan looks good. I'll look towards removing archiver in the coming weeks to progress this even further. Thanks |
Thank you! |
|
A new release would help the project! |
naveensrinivasan
added a commit
to naveensrinivasan/lnd
that referenced
this pull request
Sep 29, 2021
Included a replace directive to avoid using an high severity CVE GHSA-25xm-hr59-7c27 This library is indirectly referenced and cannot be upgraded directly. The fergusstrange/embedded-postgres#42 was merged to fix the CVE issue.
This was referenced Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded xz to fix this CVE GHSA-25xm-hr59-7c27
https://deps.dev/go/github.com%2Ffergusstrange%2Fembedded-postgres