Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go SDK SQLite support #1618

Closed
itowlson opened this issue Jun 26, 2023 · 5 comments
Closed

Go SDK SQLite support #1618

itowlson opened this issue Jun 26, 2023 · 5 comments
Assignees
Milestone

Comments

@itowlson
Copy link
Contributor

No description provided.

@itowlson
Copy link
Contributor Author

@adamreese From conversation with @rylev, he is interested in doing this but is not sure what the current plan is given the work going on for v2. What's your advice for something to be delivered in the 1.4 timeframe?

@adamreese
Copy link
Member

adamreese commented Jun 29, 2023

The v2 work currently is only for kv and redis. SQLite support can be added to v1.

@itowlson itowlson added this to the 1.4.0 milestone Jul 3, 2023
@dipankardas011
Copy link
Contributor

interested in adding support, but don't know the starting point for this Issue
Can anyone provide me some context and which things to look for?

@rylev
Copy link
Collaborator

rylev commented Jul 18, 2023

@dipankardas011 thanks for volunteering! Work on this has already started with #1630, but that work is currently stuck. I'm looking at a possible work around. If I can't get that to work, we might want to search for alternative approaches. I'll update this issue in the next day or so with what I think are the next steps. Unfortunately, there are multiple things in play that make adding this support not super straight forward.

@itowlson
Copy link
Contributor Author

This exists in the v2 Go SDK (https://pkg.go.dev/github.com/fermyon/spin/sdk/go/v2@v2.2.0/sqlite). Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants