New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Stack operations #44: isEmpty #67
Conversation
Description: Added isEmpty functionality to api. Now client can access is_empty rest call to determine if the stack associated to the pass in stack id and db id is empty or not. Testing Methodology: Verify the following curl call will return is_empty = false curl -XPUT "localhost:1205/databases?name=MY_DATABASE" curl -XPUT "localhost:1205/databases/MY_DATABASE/stacks?name=BOOKSHELF" curl -XPOST localhost:1205/databases/MY_DATABASE/stacks/BOOKSHELF \ -d '{"element":{"title":"1984","author":"George Orwell","ISBN":"1595404325","comments":[]}}' curl "localhost:1205/databases/MY_DATABASE/stacks/BOOKSHELF?is_empty" Verify the following curl call will return is_empty = true curl -XPUT "localhost:1205/databases?name=MY_DATABASE" curl -XPUT "localhost:1205/databases/MY_DATABASE/stacks?name=BOOKSHELF" curl "localhost:1205/databases/MY_DATABASE/stacks/BOOKSHELF?is_empty" Verify that empty db or stack will have standard empty response
Codecov Report
@@ Coverage Diff @@
## dev-0.2 #67 +/- ##
=======================================
Coverage 100% 100%
=======================================
Files 16 18 +2
Lines 657 778 +121
=======================================
+ Hits 657 778 +121
Continue to review full report at Codecov.
|
This looks great now 👌 I added some small fixes, mostly formatting, wording and naming related. Then with a bit of time I'll try the functionality itself, update CHANGELOG and Merge ⭐ @jlr52 can you in the meantime update the Thanks and great work! |
For sure, I will update the docs on my next pull request. Thanks for fixing the coding styles and mismatch %v, I will be more meticulous next time. |
@jlr52 you can do it in this same PR. |
Description: Added documentation for EMPTY operation Testing Methodology: n/a
Doc is added. |
Merged 🎉 |
Hi fern4lvarez,
This pull request fixes the code reviews from #65
Description:
Testing Methodology: