Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backwards compatibility with serverless < 3 #170

Merged
merged 1 commit into from Apr 25, 2023

Conversation

mikejpeters
Copy link
Collaborator

fixes #165

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@15bd652). Click here to learn what that means.
The diff coverage is 50.00%.

❗ Current head 68649e7 differs from pull request most recent head 8b09f8b. Consider uploading reports for the commit 8b09f8b to get more accurate results

@@            Coverage Diff            @@
##             master     #170   +/-   ##
=========================================
  Coverage          ?   85.21%           
=========================================
  Files             ?        6           
  Lines             ?      345           
  Branches          ?        0           
=========================================
  Hits              ?      294           
  Misses            ?       51           
  Partials          ?        0           
Impacted Files Coverage Δ
lib/plugin.js 92.43% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Shereef Shereef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good please make sure to test with v2 before merging

@Shereef
Copy link
Collaborator

Shereef commented Apr 25, 2023

@mikejpeters did you want to add tests for the new uncovered line ?

@mikejpeters
Copy link
Collaborator Author

Not really :P these changes are pretty trivial

@mikejpeters mikejpeters merged commit c8c6953 into master Apr 25, 2023
1 check passed
@mikejpeters mikejpeters deleted the backwards-compatibility branch April 25, 2023 03:25
@github-actions
Copy link

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot destructure property 'log' of 'undefined'
2 participants