Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow path to assume base href #38

Closed
andyricchuiti opened this issue Feb 27, 2020 · 3 comments
Closed

allow path to assume base href #38

andyricchuiti opened this issue Feb 27, 2020 · 3 comments
Labels
feature New feature or request wontfix

Comments

@andyricchuiti
Copy link

Problem to solve

when html head has a base tag of <base href="/test/">, would love for lit-route to not need that in path, such as <lit-route path="page1"></lit-route> instead of having to declare the base href in the path as currently <lit-route path="/test/page1"></lit-route>

Alternatives considered

currently could be solved through nested routing, but trying to avoid that if possible

Additional context

the component can be imported into different base hrefs, so i'm trying to make it agnostic to work with any base href

@andyricchuiti andyricchuiti added the question Further information is requested label Feb 27, 2020
@fernandopasik
Copy link
Owner

It's a cool feature you are suggesting. Would you like to make a PR?

@fernandopasik fernandopasik added feature New feature or request and removed question Further information is requested labels Mar 24, 2020
@andyricchuiti
Copy link
Author

awesome! will do! (sorry for just ow seeing this)

@stale
Copy link

stale bot commented Jun 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 23, 2020
@stale stale bot closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request wontfix
Projects
None yet
Development

No branches or pull requests

2 participants