Final Group Capstone - Book a Teacher

[fernandorpm]

Final Group Capstone - Book a Teacher

Size of the Team: 2 people
You can check our Project Kanban here.

[nidalaa]

Hi!

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

• please add a set of screenshots that will show all the cards on your board. This request will be approved once you do that :)

Optional suggestions

Every comment below is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

• merge columns Review in progress and Reviewer approved into one column In review, you will have the information about the approval in the PR and in the email notification. Double-checking it in the kanban board is not necessary and it produces an extra step for the reviewer.
• there is one card that is an additional feature added by you Optional - [2pt] Create Delete Booking Page #20. It is awesome and that feature makes perfect sense but please consider putting it in the bottom of the list to make sure that you implement the required features first
• please consider adding a prefix to the titles of your cards that will indicate the optional cards - this will help you to assess quickly how far you are with your progress before the final presentation
• those two cards seem to overlap as rails migrations will create the database structure: https://github.com/fernandorpm/book-a-teacher-api/issues/1 & [2pt] Create Models and Migration #6

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

---

As described in the Students Handbook you have a limited number of code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

[nidalaa]

Hi @fernandorpm and @arthurborgesdev - as the only missing thing is a set of screenshots that is easy to be done, please do the following:

• add screenshots as requested :)
• request a re-review
• continue working on the project

I will re-review it in my morning as the requested changes are not blocking your progress 💪

[fernandorpm]

Hello @nidalaa !
All of the required and optional changes have been done!
We have also asked for a re-review, as you suggested.
Thanks for the feedback! 🚀

[nidalaa]

@fernandorpm I cannot see your re-review request - can you go to your Dashboard and submit it.

Without that I cannot approve this project:)

[fernandorpm]

My bad! I thought that I was supposed to ask for the re-review (through the forms), the one that we ask for a second opinion.
Asked for another review! Thanks!

[nidalaa]

Hi @fernandorpm and @arthurborgesdev ,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

---

As described in the Students Handbook you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.