Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor crashes without a internet connection #35

Closed
juwens opened this issue Mar 29, 2019 · 1 comment
Closed

editor crashes without a internet connection #35

juwens opened this issue Mar 29, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@juwens
Copy link

juwens commented Mar 29, 2019

Describe the bug
editor crashes during start without a internet connection.

To Reproduce

  1. Disconnect all internet connections
  2. Start editor
  3. client crashes immediately in VersionChecker.CheckVersionAsync
  4. See error

Expected behavior
Editor does not crash.

Additional context
There can be other reasons for httpClient.GetAsync to fail:

  • github is down
  • connection timeout due to network or webserver weirdness
  • domain not resolved/blacklisted by your dns-server

pull request
#34

@juwens juwens added the bug Something isn't working label Mar 29, 2019
@fernandreu
Copy link
Owner

Fixed in 979ff81 (thanks again!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants