Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using native StringEncoder when available #45

Closed
feross opened this issue Sep 27, 2014 · 2 comments
Closed

Consider using native StringEncoder when available #45

feross opened this issue Sep 27, 2014 · 2 comments

Comments

@feross
Copy link
Owner

feross commented Sep 27, 2014

There's a native html5 api for string encoding and decoding. Benchmark it and see if it's faster to use it, when possible.

@mourner
Copy link

mourner commented Feb 6, 2015

Tried that here — nope. Extremely harmful for performance — with native TextEncoder/TextDecoder, it's like 5x slower in Chrome.

@feross
Copy link
Owner Author

feross commented Feb 6, 2015

Good to know. The API will probably get faster in a few years when the API is used more in the wild and there's a reason to optimize it.

I'll close this issue for now, since we can't afford a 5x perf hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants