Skip to content

Commit

Permalink
use >= in peer dep semver ranges
Browse files Browse the repository at this point in the history
  • Loading branch information
@feross
feross committed Apr 6, 2017
1 parent bcdae19 commit 0497459
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
"license": "MIT",
"main": "index.js",
"peerDependencies": {
"eslint": "^3.19.0",
"eslint-plugin-import": "^2.2.0",
"eslint-plugin-node": "^4.2.2",
"eslint-plugin-promise": "^3.5.0",
"eslint-plugin-standard": "^3.0.0"
"eslint": ">=3.19.0",
"eslint-plugin-import": ">=2.2.0",
"eslint-plugin-node": ">=4.2.2",
"eslint-plugin-promise": ">=3.5.0",
"eslint-plugin-standard": ">=3.0.0"
},
"repository": {
"type": "git",
Expand Down

2 comments on commit 0497459

@Arcanemagus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows the exact same range of peers, with the added disadvantage of not preventing major new versions from being marked as compatible.

For example some future eslint@4 is now perfectly compatible with this range, where before only eslint@3.x.y (>= v3.19.0 of course) was compatible. Was there a specific reason this change was made?

@feross
Copy link
Member Author

@feross feross commented on 0497459 Apr 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we actually want to allow newer versions to show up as compatible. There's a good chance that newer versions of eslint-plugin-node, for instance, will work just fine and we don't want to prevent them from being used.

Please sign in to comment.