Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM module has files with timestamps of Jan 1 1970 #17

Closed
seibar opened this issue Mar 18, 2018 · 4 comments
Closed

NPM module has files with timestamps of Jan 1 1970 #17

seibar opened this issue Mar 18, 2018 · 4 comments

Comments

@seibar
Copy link

seibar commented Mar 18, 2018

When I install the ieee754 module from npm, the files in that package all of a timestamp of Jan 1 1970 (or thereabouts, depending on your time zone), using npm version 4.2.0.

screen shot 2018-03-17 at 8 49 50 pm

This winds up causing an issue with the aws-cli, at least when running in circle-ci, where an error is thrown: ZIP does not support timestamps before 1980. This is detailed in this aws-cli issue: aws/aws-cli#2639. There is a workaround detailed in the aws-cli issue.

Would it be possible for you to address the issue that's causing the 1970 timestamp in the npm module?

@seibar seibar changed the title NPM module has files with timestamps of Dec 31 1969 NPM module has files with timestamps of Jan 1 1970 Mar 18, 2018
@feross
Copy link
Owner

feross commented Mar 18, 2018

Attempted to fix by republishing as 1.2.0 1.1.9

@chrisradek
Copy link

It looks like version 1.1.10 still has this issue. I didn't see a version 1.2.0 published.

@feross
Copy link
Owner

feross commented Mar 24, 2018

Okay, once more. Try 1.1.11

@tnir
Copy link

tnir commented Sep 16, 2019

Just investigated version diffs as many packages came to pin ieee754 to 1.1.8.

Sep 16 11:02 = time when tests were executed

ieee754@1.1.8 => OK

+ ieee754@1.1.8
added 1 package from 2 contributors and audited 1 package in 0.96s
found 0 vulnerabilities

total 20
-rw-r--r-- 1 root root 1506 Oct  3  2016 LICENSE
-rw-r--r-- 1 root root 1413 Oct  3  2016 README.md
-rw-r--r-- 1 root root 2054 Jun 11  2015 index.js
-rw-r--r-- 1 root root 1732 Sep 16 11:02 package.json
drwxr-xr-x 2 root root 4096 Sep 16 11:02 test

ieee754@1.1.9 => NG

+ ieee754@1.1.9
added 1 package from 2 contributors and audited 1 package in 0.953s
found 0 vulnerabilities

total 20
-rw-r--r-- 1 root root 1506 Sep 16 11:02 LICENSE
-rw-r--r-- 1 root root 1651 Sep 16 11:02 README.md
-rw-r--r-- 1 root root 2064 Sep 16 11:02 index.js
-rw-r--r-- 1 root root 1799 Sep 16 11:02 package.json
drwxr-xr-x 2 root root 4096 Sep 16 11:02 test

ieee754@1.1.10 => NG

+ ieee754@1.1.10
added 1 package from 2 contributors and audited 1 package in 0.499s
found 0 vulnerabilities

total 20
-rw-r--r-- 1 root root 1506 Sep 16 11:02 LICENSE
-rw-r--r-- 1 root root 1651 Sep 16 11:02 README.md
-rw-r--r-- 1 root root 2064 Sep 16 11:02 index.js
-rw-r--r-- 1 root root 1807 Sep 16 11:02 package.json
drwxr-xr-x 2 root root 4096 Sep 16 11:02 test

ieee754@1.1.11 => OK

+ ieee754@1.1.11
added 1 package from 2 contributors and audited 1 package in 0.503s
found 0 vulnerabilities

total 20
-rw-r--r-- 1 root root 1506 Oct 26  1985 LICENSE
-rw-r--r-- 1 root root 1651 Oct 26  1985 README.md
-rw-r--r-- 1 root root 2064 Oct 26  1985 index.js
-rw-r--r-- 1 root root 1807 Sep 16 11:02 package.json
drwxr-xr-x 2 root root 4096 Sep 16 11:02 test

ieee754@1.1.12 => OK

+ ieee754@1.1.12
added 1 package from 2 contributors and audited 1 package in 0.519s
found 0 vulnerabilities

total 16
-rw-r--r-- 1 root root 1506 Oct 26  1985 LICENSE
-rw-r--r-- 1 root root 1651 Oct 26  1985 README.md
-rw-r--r-- 1 root root 2064 Oct 26  1985 index.js
-rw-r--r-- 1 root root 1807 Sep 16 11:02 package.json

ieee754@1.1.13 => OK

+ ieee754@1.1.13
added 1 package from 2 contributors and audited 1 package in 0.578s
found 0 vulnerabilities

total 16
-rw-r--r-- 1 root root 1465 Oct 26  1985 LICENSE
-rw-r--r-- 1 root root 1821 Oct 26  1985 README.md
-rw-r--r-- 1 root root 2064 Oct 26  1985 index.js
-rw-r--r-- 1 root root 1807 Sep 16 11:02 package.json

Procedure

Environment

  • macOS 10.15 Beta (19A546d)

  • Docker for mac 2.1.0.2 (37877)

  • Node.js: v12.10.0

  • node:latest@sha256:d8c33ae35f44cb330d917cdea6e0ee4b1e4b6e18ddd54700dbd0636606d64e4e

Commands

$ for v in {8..13}; do docker run --rm -it node bash -c "npm i -q -s ieee754@1.1.$v; ls -l node_modules/ieee754"; done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants