Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message from render-media call to videostream #73

Closed
mitra42 opened this issue Jan 8, 2020 · 1 comment
Closed

Warning message from render-media call to videostream #73

mitra42 opened this issue Jan 8, 2020 · 1 comment

Comments

@mitra42
Copy link

mitra42 commented Jan 8, 2020

Looks like a bug to me ...

    function useVideostream () {
      debug('Use `videostream` package for ' + file.name)
      prepareElem()
      elem.addEventListener('error', fallbackToMediaSource)
      elem.addEventListener('loadstart', onLoadStart)
      elem.addEventListener('canplay', onCanPlay)
      videostream(file, elem)
    }

And then in videostream (@jhiesey )

function VideoStream (file, mediaElem, opts = {}) {
  if (!(this instanceof VideoStream)) {
    console.warn("don't invoked VideoStream without 'new'")
    return new VideoStream(file, mediaElem, opts)
  }

I'm getting a console warning from this combination.

@feross
Copy link
Owner

feross commented Nov 18, 2020

Fixed in f4927dd

@feross feross closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants