New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete string escaping or encoding on cmd.js #136

Closed

matbrgz opened this issue Apr 18, 2019 · 1 comment

matbrgz commented Apr 18, 2019

A string transformer that does not replace or escape all occurrences of a meta-character may be ineffective.

root/bin/cmd.js

`${registryUrl()}${pkgName.replace('/', '%2F')}`
This replaces only the first occurrence of '/'.

https://lgtm.com/projects/g/feross/thanks/alerts/?mode=tree&ruleFocus=1506222917439

The text was updated successfully, but these errors were encountered:

Owner

feross commented Aug 13, 2019

Thanks, fixed

feross closed this as completed in

5a6a92d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment