Deselect was not working #2435
Closed
Deselect was not working #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 30, 2022 15:18
… a specific priority, then it will never be "deselected"
nuzzesick
approved these changes
Jan 6, 2023
nuzzesick
approved these changes
Jan 21, 2023
|
@drakonkat is there any problem? why you closed it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deselect was not working especially if you first "select" a file with a specific priority, then it will never be "deselected"
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
I have changed file.js calling a new method in torrent.js.
I have created a method deselect in torrent.js which doesn't care about priority because if you want to deselect a file you want that will not be downloaded. I have not deleted the previous deselect method because maybe can be used elsewhere, if not it can be deleted.
I have updated the docs too
Which issue (if any) does this pull request address?
#164
Is there anything you'd like reviewers to focus on?
If is possible to write some test about it or if there is some guide on how to write it well