tests

geoopt · Mar 2, 2019 · 7fc3669 · 7fc3669
1 parent 10b4c84
commit 7fc3669
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/geoopt/manifolds/euclidean.py b/geoopt/manifolds/euclidean.py
@@ -50,5 +50,5 @@ def _transp2y(self, x, v, *more, y):
     def _logmap(self, x, y):
         return y - x
 
-    def _dist(self, x, y):
+    def _dist(self, x, y, keepdim):
         return (x - y).abs()
diff --git a/geoopt/manifolds/sphere.py b/geoopt/manifolds/sphere.py
@@ -88,7 +88,7 @@ def _expmap_transp(self, x, v, *more, u, t):
 
     def _logmap(self, x, y):
         u = self._proju(x, y - x)
-        dist = self._dist(x, y).unsqueeze(-1)
+        dist = self._dist(x, y, keepdim=True)
         # If the two points are "far apart", correct the norm.
         cond = dist.gt(1e-6)
         return torch.where(cond, u * dist / u.norm(dim=-1, keepdim=True), u)

diff --git a/tests/test_manifold.py b/tests/test_manifold.py
@@ -40,8 +40,6 @@ def t(request):
     ],
 )
 def manifold(request, retraction_order):
-    if not issubclass(request.param, geoopt.manifolds.PoincareBall):
-        pytest.skip(".")
     man = request.param()
     try:
         return man.set_default_order(retraction_order)