fix typo

geoopt · Mar 2, 2019 · 8a815e8 · 8a815e8
1 parent 7fc3669
commit 8a815e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/docs/plots/extended/poincare/distance2plane.py b/docs/plots/extended/poincare/distance2plane.py
@@ -13,7 +13,7 @@
 dist2 = xx ** 2 + yy ** 2
 mask = dist2 <= radius ** 2
 grid = np.stack([xx, yy], axis=-1)
-dists = pmath.dist2plane(torch.from_numpy(grid).float(), v, x)
+dists = pmath.dist2plane(torch.from_numpy(grid).float(), x, v)
 dists[(~mask).nonzero()] = np.nan
 circle = plt.Circle((0, 0), 1, fill=False, color="b")
 plt.gca().add_artist(circle)

diff --git a/geoopt/manifolds/poincare/math.py b/geoopt/manifolds/poincare/math.py
@@ -935,7 +935,7 @@ def mobius_fn(x, *args, c=1.0, **kwargs):
     return mobius_fn
 
 
-def dist2plane(x, a, p, *, c=1.0, keepdim=False, signed=False):
+def dist2plane(x, p, a, *, c=1.0, keepdim=False, signed=False):
     r"""
     Distance from :math:`x` to a hyperbolic hyperplane in Poincare ball
     that is orthogonal to :math:`a` and contains :math:`p`.
@@ -1028,7 +1028,7 @@ def dist2plane(x, a, p, *, c=1.0, keepdim=False, signed=False):
     x : tensor
         point on poincare ball
     a : tensor
-        point on poincare ball, that is orthogonal to hyperplane
+        vector on tangent space of :math:`p`
     p : tensor
         point on poincare ball lying on the hyperplane
     c : float|tensor