Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what about the offline option #62

Closed
ec1oud opened this issue Dec 12, 2020 · 4 comments
Closed

what about the offline option #62

ec1oud opened this issue Dec 12, 2020 · 4 comments

Comments

@ec1oud
Copy link

ec1oud commented Dec 12, 2020

ipfs name publish bafy... --offline works fast on the command line, but by default we still wait for the publishing to succeed, so rust code that calls name_publish is slow. There should be a way to give the offline option to any function, including this one. See ipfs/js-ipfs#2569 and sorry if I'm missing something; I'm still new to rust.

@ferristseng
Copy link
Owner

This has been the pattern for adding options to the API calls: #61

@ec1oud
Copy link
Author

ec1oud commented Dec 14, 2020

It's not so important though, because offline means it will never be published, only local, which is not what I was looking for.

@jcaesar
Copy link
Contributor

jcaesar commented Jan 8, 2021

The offline option is kind of important because it's the only sane way that allows checking whether content is local: https://discuss.ipfs.io/t/how-to-check-if-an-ipfs-object-is-on-your-local-node/1250/2 I was planning on adding it for that.

@ferristseng That pattern won't help in this case, since it's a global option, applicable to any command.

@jcaesar
Copy link
Contributor

jcaesar commented Oct 18, 2021

I suppose #87 closes this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants