You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I spent a little time looking at why when I run TRYBUILD=overwrite carto test the *.stderr files do not have $DIR/xxx in the output. My conclusion is the compiler use to include the $DIR/xxx output, but now outputs the actual path.
You can see that in this change on trybuild the stderr test files were updated and they do not have the $DIR/xxx:
So my suggestion is that in the future we don't manually add the $DIR/ and instead use the generated files as is. If you'd like I can create another PR with the those unmodified files.
The text was updated successfully, but these errors were encountered:
thanks for the report. I'd like to keep the content of this repo in line with the content of the blog post and not modify either so, I have pinned the compiler version and dependencies in e431fcd . This way others should be able to reproduce the results regardless of what their default toolchain is.
I spent a little time looking at why when I run
TRYBUILD=overwrite carto test
the*.stderr
files do not have$DIR/xxx
in the output. My conclusion is the compiler use to include the$DIR/xxx
output, but now outputs the actual path.You can see that in this change on trybuild the stderr test files were updated and they do not have the
$DIR/xxx
:So my suggestion is that in the future we don't manually add the
$DIR/
and instead use the generated files as is. If you'd like I can create another PR with the those unmodified files.The text was updated successfully, but these errors were encountered: