Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUR Repository package #73

Closed
CupricReki opened this issue Jan 15, 2024 · 13 comments
Closed

AUR Repository package #73

CupricReki opened this issue Jan 15, 2024 · 13 comments

Comments

@CupricReki
Copy link
Contributor

I created the lan-mouse package in the aur. Please review and let me know your thoughts. I've never worked with cargo and this is my first submission to the AUR.

https://aur.archlinux.org/packages/lan-mouse-git

I'm waiting for #72 before I add .desktop support. I'll add a service file for systemd once #70 and the daemon issues get sorted out.

AUR package for bin is forthcoming.

@feschber
Copy link
Owner

First of all: Thank you for your work!

I took a look and have nothing to complain.

One thing to note is that /usr/share/pixmaps is deprecated.
You should probably move the icon to /usr/share/icons/hicolor/scalable/apps/de.feschber.LanMouse.svg now.

I also fixed the Icon Name and App Id such that it should now be correctly displayed:
13597b3

@feschber
Copy link
Owner

(sorry for already breaking the PKGBUILD) Could you add me as a maintainer? My name on the AUR is feschber as well.

@feschber
Copy link
Owner

If I put the icon under

/usr/share/icons/hicolor/scalable/apps/de.feschber.LanMouse.svg

and run

sudo gtk-update-icon-cache /usr/share/icons/hicolor/

It appears in both Gnome and KDE.

@feschber
Copy link
Owner

And regarding the systemd service, maybe you can share some ideas, @alison-solsoft
( #68 (comment))

@CupricReki
Copy link
Contributor Author

Thanks for the feedback and the updates. The AUR lan-mouse-git package has been updated.

@CupricReki
Copy link
Contributor Author

Added the bin package as well.

https://aur.archlinux.org/packages/lan-mouse-bin

@alison-solsoft
Copy link

Coincidentally, I was going to work on an AUR package myself once #70 was resolved, so thanks for taking it on already @CupricReki!

@feschber I have some thoughts relevant to running lan-mouse as a system daemon, but they are things that would need to be handled by packagers in general. I'll comment on the issue that Cupric created specific to the creation of a systemd unit (#76)

@feschber
Copy link
Owner

FYI @CupricReki: Adding me in the AUR worked, thanks!

@CupricReki
Copy link
Contributor Author

Should I add an an example config to the package? Seems like the the correct location would be /etc/lan-mouse/config.toml.

@alison-solsoft
Copy link

An example config would be a good thing to include in the package. I would use /etc/lan-mouse/examples/config.toml to avoid potential conflicts if / when a package update modifies the example config, but that would only be an issue if it becomes possible to run lan-mouse as a system service, and /etc/lan-mouse/config.toml is used for configuration.

@feschber
Copy link
Owner

The config.toml from the repository basically already serves as an example config. I guess you could just install that alongside. Also could you add me as a maintainer for the -bin package as well?

@feschber
Copy link
Owner

I added the installation instructions to the README.md

Will close this issue for now

@feschber
Copy link
Owner

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants