New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BaseStorage Async #6

Closed

festinuz opened this issue Jul 21, 2017 · 0 comments · Fixed by #10

Assignees

Labels

Owner

festinuz commented Jul 21, 2017

As suggested by robin-gvx on reddit:

library relies heavily on asyncio, but for some reason get and set aren't required to be coroutines, but are coerced to be coroutines by the library. Why? If you're going to use them asynchronously anyway, why not require the user to write get and set as coroutines?

Perhaps abstract methods of BaseStorage should be defined as async methods.

festinuz added the enhancement label

festinuz self-assigned this

This was referenced Jul 22, 2017

Async basestorage #9

Merged

Merged

festinuz closed this as completed in #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment