-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build-public
incorrectly deletes nested components
#151
Labels
Milestone
Comments
mmarseu
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Apr 9, 2024
mmarseu
changed the title
_build-public_ incorrectly deletes nested components
Apr 9, 2024
build-public
incorrectly deletes nested components
mmarseu
changed the title
"build-public" incorrectly deletes nested components
Apr 9, 2024
build-public
incorrectly deletes nested components
mmarseu
changed the title
"build-public" incorrectly deletes nested components
Apr 11, 2024
build-public
incorrectly deletes nested components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The build-public command is meant to delete components marked as internal. It isn't documented what it does with non-internal components nested inside those internal components.
The tool should probably either:
This is likely the more logical choice, as users might expect components bundled inside internal components to also disappear from the SBOM.
Instead, here is what actually happens:
We should choose one of the options above, implement it and make it explicit in the documentation.
The text was updated successfully, but these errors were encountered: