Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-public incorrectly deletes nested components #151

Closed
mmarseu opened this issue Apr 9, 2024 · 0 comments · Fixed by #200
Closed

build-public incorrectly deletes nested components #151

mmarseu opened this issue Apr 9, 2024 · 0 comments · Fixed by #200
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@mmarseu
Copy link
Collaborator

mmarseu commented Apr 9, 2024

The build-public command is meant to delete components marked as internal. It isn't documented what it does with non-internal components nested inside those internal components.

The tool should probably either:

  1. Delete nested components and remove them from the dependency tree the same way as internal components.
    This is likely the more logical choice, as users might expect components bundled inside internal components to also disappear from the SBOM.
  2. Leave nested components in the SBOM and move them up to the parent scope.

Instead, here is what actually happens:

  • Delete any component marked as internal, including nested components.
  • Remove dependencies on the internal component.
  • Do not remove dependencies on the nested components, leaving dependencies to components behind, which aren't part of the SBOM anymore.

We should choose one of the options above, implement it and make it explicit in the documentation.

@mmarseu mmarseu added bug Something isn't working documentation Improvements or additions to documentation labels Apr 9, 2024
@mmarseu mmarseu changed the title _build-public_ incorrectly deletes nested components build-public incorrectly deletes nested components Apr 9, 2024
@mmarseu mmarseu changed the title build-public incorrectly deletes nested components "build-public" incorrectly deletes nested components Apr 9, 2024
@mmarseu mmarseu changed the title "build-public" incorrectly deletes nested components build-public incorrectly deletes nested components Apr 11, 2024
mmarseu added a commit that referenced this issue Apr 11, 2024
mmarseu added a commit that referenced this issue May 23, 2024
mmarseu added a commit that referenced this issue May 28, 2024
mmarseu added a commit that referenced this issue Jun 20, 2024
mmarseu added a commit that referenced this issue Jul 2, 2024
mmarseu added a commit that referenced this issue Jul 2, 2024
@italvi italvi added this to the 1.0.0 milestone Jul 3, 2024
mmarseu added a commit that referenced this issue Jul 4, 2024
mmarseu added a commit that referenced this issue Jul 10, 2024
mmarseu added a commit that referenced this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants