Add argument to select launching teleop

[708yamaguchi]

In this PR, I add argument to select launching teleop in fetch.launch.

I need this argument because I want to launch our original teleop program in other launch file.

Cc @knorth55

[knorth55]

We need this PR to customize our fetch teleoperation PS3joystick command.
We want to set similar joystick command as PR2.

[moriarty]

Seems reasonable.

@erelson @cjds any thoughts before merging this?

[cjds]

LGTM good idea

[erelson]

Seems fine, though my own typical approach would just be to comment out the teleop portion of /etc/ros/$distro/robot.launch

Note that in order for this change to take effect on your current robot(s), you must manually update your robot.launch file! The file you've modified is only used at install time when the fetch-melodic-config package creates /etc/ros/melodic/robot.launch by copying it.

[knorth55]

Seems fine, though my own typical approach would just be to comment out the teleop portion of /etc/ros/$distro/robot.launch

Note that in order for this change to take effect on your current robot(s), you must manually update your robot.launch file! The file you've modified is only used at install time when the fetch-melodic-config package creates /etc/ros/melodic/robot.launch by copying it.

Thank you for your information.
We already change /etc/ros/indigo/robot.launch for calibration data.

[moriarty]

Seems fine, though my own typical approach would just be to comment out the teleop portion of /etc/ros/$distro/robot.launch

Note that in order for this change to take effect on your current robot(s), you must manually update your robot.launch file! The file you've modified is only used at install time when the fetch-melodic-config package creates /etc/ros/melodic/robot.launch by copying it.

I think commenting out code in /etc should be avoided. I think we should have this PR, and open a related issue for looking into fetch-melodic-config to use a symlink or something similar so that this change could become effective.

If you don’t want to add the frieght change, we can open a new issue for that and merge this PR as is.

[708yamaguchi]

Thank you for your review.
I pushed an additional commit and added freight change.

I also created a PR (#41 ) for indigo.
Could you merge this if there is no problem?