Added fixed dae models compatible with OpenWebGL #105
Conversation
…ks like red emergency button
|
Could you provide some summary information on what changes are needed to ensure openwebgl compatibility? I would like to pass that info on to the person who historically creates these files. Additionally, assuming you intend this to be merged eventually, go ahead and give the files the actual names (no .fix) 👍 Thanks! |
|
@erelson Just committed the name changes to their original names. Please let me know if you fetchers accepts and merge the changes to the main repo so that I can update everywhere where we are using these files to use the main repo. For future changes, I suppose this fork and pull request method is the one to use? As for the method to make dae files compatible with OpenWebGL, its quite tricky and I can't tell you exactly what has to be done with precision. The problem is that WebGL has some issues with certain ways of exporting textures and materials and depending on the program used and method to export those files, they just don't appear or they appear without textures. I recommend using plain textures mapped with UV or materials using Blender render ( not cycles material systems ). Sorry, I can't give you more details, but that's the way we generated these dae files, iteratively until they worked in both Gazebo and WebGL. If someone knows more about the topic please let us know. |
fetch_description/robots/fetch.urdf
Outdated
| @@ -565,7 +565,7 @@ | |||
| <child link="laser_link" /> | |||
| <axis xyz="0 0 0" /> | |||
| </joint> | |||
| <link name="torso_fixed_link"> | |||
| <link name="torsoed_link"> | |||
There was a problem hiding this comment.
Let's keep the original link/joint name of torso_fixed_joint, as well.
There was a problem hiding this comment.
Ok Fixed I think now. Made a replace to fast ;).
Tell me if there is anything else and notify me if we merge
|
Thanks for the quick fixes! I've gotta check/test with a few others before going ahead and merging this. If you're able to provide screenshots in RViz before/after, that will help demonstrate that the changes are tested and look OK. |
|
Is that ok? I dont have the footage that showed how it appered before, didnt print it. |
|
LGTM |
fetch_description/robots/fetch.urdf
Outdated
| @@ -587,7 +587,7 @@ | |||
| </geometry> | |||
| </collision> | |||
| </link> | |||
| <joint name="torso_fixed_joint" type="fixed"> | |||
| <joint name="torsoed_joint" type="fixed"> | |||
There was a problem hiding this comment.
@RDaneelOlivav sorry I didn't specify before, but there were multiple instances needing to be reverted to the original.
There was a problem hiding this comment.
I thought I had fixed that in this commit: 47b9745
Is there something I'm missing here? There were two places where there was an error. Is there anywhere else?
There was a problem hiding this comment.
Yeah, this is weird. Your commit's (the most recent one) diffs look correct, but when viewing the full diffs, the current version of the file is wrong for this line. I can easily fix that and am doing so now.
There was a problem hiding this comment.
There were actually three places, I see now. 👍
Here we added new versions of the Dae files that are compatible with OpenWebGL and minor material tweeks like the red emergency button.