Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zip file should not be committed to repository #26

Closed
pdf opened this issue Aug 17, 2020 · 2 comments
Closed

zip file should not be committed to repository #26

pdf opened this issue Aug 17, 2020 · 2 comments
Assignees
@Feu-Secret
Labels
enhancement New feature or request

Comments

@pdf
Copy link
Collaborator

pdf commented Aug 17, 2020

Committing binaries to the git repo is poor form - binaries cannot be stored or diff'd efficiently, so the repository size grows dramatically over time.

Consider instead using the releases feature on Github to attach the zip to a tag.
@Feu-Secret Feu-Secret self-assigned this Aug 17, 2020
@Feu-Secret Feu-Secret added the enhancement New feature or request label Aug 17, 2020
@Feu-Secret
Copy link
Owner

You're right. The zip will be published with a release and the module.json download link will point to it.

@Feu-Secret
Copy link
Owner

done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Feu-Secret Feu-Secret

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pdf @Feu-Secret