Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Rotate Effect #35

Closed
Dumbhuman opened this issue Aug 26, 2020 · 7 comments
Closed

Enhancement: Rotate Effect #35

Dumbhuman opened this issue Aug 26, 2020 · 7 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@Dumbhuman
Copy link

I know that there's a mechanical rotation tied to tokens in game, but I would love the ability to just rotate the image of a token without changing its functional rotation. This could be used to quickly fix tokens not set up to face south (Foundry's default assumption) as well as to animate rotation for spell templates on things like Fog Cloud, Whirlwind, Dust Devil, etc. (my primary goal).

@Feu-Secret
Copy link
Owner

Sprites transformation is a functionality in the pipeline (translation, rotation, shrinking, enlarging). I cannot give a deadline yet. In the meantime, to simulate a rotation, you can use a twist filter with a very large radius (not very efficient, but works).

@Feu-Secret Feu-Secret self-assigned this Aug 27, 2020
@Feu-Secret Feu-Secret added the enhancement New feature or request label Aug 27, 2020
@Dumbhuman
Copy link
Author

Yeah, I figured out that trick with the Twist filter a while ago, but I'm not sure if it's possible to animate that to get a consistent clockwise spin. It can work as a quick fix to the default orientation scenario though.

Anyway, I'm glad to hear that you're already planning for other transformation features as well. My little flying effect currently uses the Bulge filter with a large radius to enlarge/shrink as well as the Twist Filter with a large radius to get some oscillating rotation so it sounds like it will get a nice performance boost in the future.

@Feu-Secret
Copy link
Owner

Yeah, I figured out that trick with the Twist filter a while ago, but I'm not sure if it's possible to animate that to get a consistent clockwise spin. It can work as a quick fix to the default orientation scenario though.

Not with a twist filter, distortion is inevitable.

Anyway, I'm glad to hear that you're already planning for other transformation features as well. My little flying effect currently uses the Bulge filter with a large radius to enlarge/shrink as well as the Twist Filter with a large radius to get some oscillating rotation so it sounds like it will get a nice performance boost in the future.

It's pulling out the chainsaw when you just need a butter knife. I know 😄

@Feu-Secret Feu-Secret added this to the v0.4.1-alpha milestone Aug 28, 2020
@Feu-Secret
Copy link
Owner

done !

@Dumbhuman
Copy link
Author

Working very well for me!

One tiny detail, but "clockWise: false" seems to be required to get an actual clockwise rotation while "clockWise: true" appears to produce counter-clockwise rotation.

@Feu-Secret
Copy link
Owner

One tiny detail, but "clockWise: false" seems to be required to get an actual clockwise rotation while "clockWise: true" appears to produce counter-clockwise rotation.

oops... i will fix it for the next release.

@Feu-Secret Feu-Secret reopened this Aug 30, 2020
@Feu-Secret Feu-Secret added the bug Something isn't working label Aug 30, 2020
@Feu-Secret Feu-Secret modified the milestones: v0.4.1-alpha, v0.4.2-alpha Aug 30, 2020
@Feu-Secret
Copy link
Owner

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants