Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokenmagicFX ignores foundry routePrefix for assets paths #59

Closed
js-murph opened this issue Oct 22, 2020 · 1 comment · Fixed by #90 or #115
Closed

tokenmagicFX ignores foundry routePrefix for assets paths #59

js-murph opened this issue Oct 22, 2020 · 1 comment · Fixed by #90 or #115
Assignees
Labels
bug Something isn't working
Milestone

Comments

@js-murph
Copy link

tokenmagicFX seems to ignore the routePrefix foundry option when configured for determining its default asset paths.

For example if routePrefix = "thing" all content is going to be at the base path of https://mydomain/thing/. The current behaviour of tokenmagicFX results in the following...

GET https://mydomain:8080/modules/tokenmagic/fx/assets/distortion-1.png 404
ImageResource.ts:188 Uncaught (in promise) Event {isTrusted: true, type: "error", target: null, currentTarget: null, eventPhase: 0, …}

It should however be doing...

GET https://mydomain:8080/myprefix/modules/tokenmagic/fx/assets/distortion-1.png
@Feu-Secret Feu-Secret self-assigned this Oct 23, 2020
@Feu-Secret Feu-Secret added the bug Something isn't working label Oct 23, 2020
@Feu-Secret Feu-Secret added this to the v0.4.5-alpha milestone Oct 23, 2020
@Feu-Secret Feu-Secret modified the milestones: v0.4.5-alpha, v0.5.1-beta Dec 17, 2020
@Feu-Secret Feu-Secret linked a pull request Feb 16, 2021 that will close this issue
Feu-Secret added a commit that referenced this issue Feb 17, 2021
@dev7355608 dev7355608 modified the milestones: v0.5.1-beta, v0.5.0-beta Apr 15, 2021
@Feu-Secret Feu-Secret linked a pull request Apr 26, 2021 that will close this issue
@Feu-Secret
Copy link
Owner

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants