Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test case 都跑不过,确定是最新版? #41

Open
iulo opened this issue Aug 23, 2016 · 2 comments
Open

test case 都跑不过,确定是最新版? #41

iulo opened this issue Aug 23, 2016 · 2 comments

Comments

@iulo
Copy link

iulo commented Aug 23, 2016

问题1: preload是否已移除
问题2:https://github.com/fex-team/mod/blob/master/mod.js#L97 应该为id + '.js'?

@hefangshi
Copy link
Member

  1. preload已经移除了
  2. 不是 id + '.js',首先基本上进这个分支的时候基本说明资源指定已经有问题了,大部分情况是ID指定错误,他只能期待用户指定的是一个外部资源URL而不是id,所以不需要在添加 .js

@iulo
Copy link
Author

iulo commented Aug 24, 2016

@hefangshi
如果这样,那test里的resourceMap是错误的?
https://github.com/fex-team/mod/blob/master/test/test.html#L20
test中的single/engine.js并没有作为一级对象放在res下面,对deps findNeed的时候,实际resMap中是没有对应的映射的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants