Optional columns when inserting

[gilbert]

I noticed nullable columns are still required to specify when inserting. For example:

export class Test {
  id = new UuidColumn().primaryKey().notNull();
  name = new TextColumn();
  createdAt = new TimestampWithTimeZoneColumn().notNull().default(new Now());
}
// ...
db.insertInto(db.test).values({
  name: null,
  createdAt: null,
})

here name: null is required even though it's nullable and createdAt: null is required even though it has a default.

Is this a limitation that you ran into? Or just haven't gotten around to making them optional in JS-land too? I can write a PR if it's possible.

[martijndeh]

Nowadays it’s possible to omit some types, that’s how the id property is excluded. But it’s hardcoded now so not really elegant.

It might be possible today to omit nullable and not null with defaults but I haven’t investigated further. I agree it would be nice if those nullable or default values may be omitted! So if you have time would be nice to understand if and how we can fix this! :)

[gilbert]

I have some questions about the code base. What's a good way to contact you? Perhaps https://gitter.im?

[martijndeh]

I’m working on something which solves this.

[martijndeh]

The changes are available in mammoth@next. Still needs some work to get the new set up in shape.

[gilbert]

Looks great so far! Super exciting.

[martijndeh]

Tests are passing again. I'll close this now as I consider this resolved. I'll try to get a release ready in the next few days. There is still some work left on the cli and the generator.