Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for id3v1 tag in file. #96

Open
dogwatch opened this issue Jun 4, 2019 · 1 comment
Open

Search for id3v1 tag in file. #96

dogwatch opened this issue Jun 4, 2019 · 1 comment

Comments

@dogwatch
Copy link

dogwatch commented Jun 4, 2019

if (this.scanid3v1 && c1 === 84 && c2 === 65 && c3 === 71) {

Is there a reason id3v1 is searched all over the file?

@ffalt
Copy link
Owner

ffalt commented Jun 5, 2019

yes and no. only the last 200 bytes of a current chunk are checked. but i agree, if the stream size is available (it may be not), I can take that into account, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants