Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrega 01 - Luís Taira #8

Open
LhTaira opened this issue Aug 28, 2021 · 1 comment
Open

Entrega 01 - Luís Taira #8

LhTaira opened this issue Aug 28, 2021 · 1 comment

Comments

@LhTaira
Copy link

LhTaira commented Aug 28, 2021

Nome: Luís Henrique Pereira Taira
Matrícula: 17/0109208
Repositório: https://github.com/LhTaira/Workshop-Docker-Entrega-01

@renatocoral
Copy link

Item Nota Observações
Entrega 1. Containerização nos dockerfiles faltou utilizar o docker-layering cache de forma mais adequada para otimizar a build (primeiro copiar o package.json, instalar as dependencias e depois copiar o codigo); acredito que seria interessante incluir volumes linkando o código dos serviços, pra que quando uma alteração seja feita você nao precise parar & rebuildar os containers
Link para o repositório da solução do aluno
Container do Front-end 2,0
Container do Back-end Microsserviço users-service 1,0 poderia ter utilizado um script de entrypoint no dockerfile
Container do Back-end chat-service 1,0
Container do Back-end api-gateway 1,0
Container dos Bancos de Dados 1,0 seria interessante utilizar um .env para não 'hardcodar' as informações sensiveis (usuario e senha)
Automação entre os containers (Docker-compose) 4,0
Total 10,0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants