Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units #49

Closed
sevenoffline opened this issue Mar 28, 2022 · 5 comments
Closed

Units #49

sevenoffline opened this issue Mar 28, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@sevenoffline
Copy link

This is probably not very important, but it would be nice to have units displayed. For example there's no unit shown on the Z-offset slider. Since this value is directly related to the resulting object's dimensions it would be nice, too to show some information about how large the resulting model will be.

Typical use case: I want the object to be exactly 1cm thick (base height). I set that and generate the object. In my slicer I notice, the object is too large for my printer and I have to scale it down by 50%. Now my object is only 0.5cm thick. Arrrgh! Back to the website, set the offset to 2cm, re-generate, ...

Dream-solution A: after the rectangle has been drawn, the dimensions are displayed with the possibility to scale them (with locked ratio).
Dream-solution-B: a value can be entered for the largest object-dimension - if it's set to "square" that value will be used for both dimensions.

@fgebhart
Copy link
Owner

That is actually a good catch. Most likely you already have generated more STL files via the streamlit app, than I did 😉

Mapa provides a feature to specify the desired model (stl file) dimensions aka model size. It should be rather straight forward to add another input widget (again a st.slider or st.number_input maybe) to the "customization" section within the sidebar and pass that value to convert_bbox_to_stl. A hint within the tooltips/help that the values are in millimeter should help in making the dimensions transparent.

Since the web app you are interacting with is based on streamlit, the possibilities to what can be implemented are somewhat limited. I do not have the complete freedom of implementing whatever html or javascript what I want. However, using streamlit allows for building data apps super fast, which is why I prefer to keep it that simple.

Because of that, I'd propose to go for dream-slution-B, as described. And as I said, implementing this feature is straight forward, because of that I'd like to ask, if you are willing to give it a try yourself? If yes, I'd add a little section on "development" to the readme and provide support and more details if needed. If not, no worries, I will try to take care of it soon, just let me know.

Keep it going with the great suggestions!

@fgebhart
Copy link
Owner

fgebhart commented Mar 29, 2022

fyi, just added this brief section on development and contributions: https://github.com/fgebhart/mapa-streamlit#development--contributions

@sevenoffline
Copy link
Author

sevenoffline commented Mar 30, 2022

:D thanks for the offer (really!) but no. I'm a pro-user by heart and I like it very much to help you with this from the user-perspective. I may have the understanding of how smth should be designed to be easily usable and I may have a intuition of the possibilities/limitations of the coding behind that but I very much lack the micro-logic that is necessary in coding. And maybe that's even better: I'm not burdened by the "how" and you are not burdened too much by the "what".

@fgebhart
Copy link
Owner

Sure, no problem. Anyway, I appreciate your suggestions and feature requests 👍

@fgebhart
Copy link
Owner

fgebhart commented Apr 2, 2022

It is now possible to specify the desired model size (in millimeter) via the model size slider. With this the impact of z-offset is directly available in millimeter and your described workflow should be simplified.

@fgebhart fgebhart closed this as completed Apr 2, 2022
@fgebhart fgebhart added the enhancement New feature or request label Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants