Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the computation is killed quickly when timeout is exceeded #570

Closed
novoj opened this issue May 20, 2024 · 1 comment · Fixed by #626
Closed

Ensure the computation is killed quickly when timeout is exceeded #570

novoj opened this issue May 20, 2024 · 1 comment · Fixed by #626
Assignees
@novoj
Labels
enhancement New feature or request
Milestone
Beta

Comments

@novoj
Copy link
Collaborator

novoj commented May 20, 2024

We set strict timeouts for requests made via HTTP endpoints, but these timeouts probably don't end the execution of the requests - they just interrupt the thread, which is not checked in the request evaluation. We need to cover this part with tests and introduce injection points that would check the thread interrupt state and terminate early if an interrupt is detected.
@novoj novoj self-assigned this May 20, 2024
@novoj novoj added the enhancement New feature or request label May 20, 2024
@novoj novoj added this to the Beta milestone May 20, 2024
novoj added a commit that referenced this issue May 20, 2024
@novoj
fix(#570): Ensure the computation is killed quickly when timeout is e…
e4bf90f 
…xceeded

We set strict timeouts for requests made via HTTP endpoints, but these timeouts probably don't end the execution of the requests - they just interrupt the thread, which is not checked in the request evaluation. We need to cover this part with tests and introduce injection points that would check the thread interrupt state and terminate early if an interrupt is detected.
@novoj
Copy link
Collaborator Author

novoj commented Jun 10, 2024

This issue is realized inside branch #41

novoj added a commit that referenced this issue Jun 10, 2024
@novoj
feat(#570): Ensure the computation is killed quickly when timeout is …
c621439 
…exceeded

We set strict timeouts for requests made via HTTP endpoints, but these timeouts probably don't end the execution of the requests - they just interrupt the thread, which is not checked in the request evaluation. We need to cover this part with tests and introduce injection points that would check the thread interrupt state and terminate early if an interrupt is detected.
novoj added a commit that referenced this issue Jun 10, 2024
@novoj
feat(#570): Ensure the computation is killed quickly when timeout is …
e3c33fe 
…exceeded

Added interruptions to GraphQL library as well.
novoj added a commit that referenced this issue Jun 10, 2024
@novoj
feat(#570): Ensure the computation is killed quickly when timeout is …
4132c9f 
…exceeded

Added support for asynchronous querying.
lukashornych added a commit that referenced this issue Jun 10, 2024
@lukashornych
feat(#570): support for different execution timeouts in GQL depending…
3a3b52c 
… on operation
lukashornych added a commit that referenced this issue Jun 10, 2024
@lukashornych
feat(#570): support for different execution timeouts in GQL depending…
cb31e8b 
… on operation
@novoj novoj closed this as completed Jun 10, 2024
@novoj novoj linked a pull request Jul 9, 2024 that will close this issue
feat(#41): create and document backup restore vacuum process #626
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novoj novoj

Labels
enhancement New feature or request
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

feat(#41): create and document backup restore vacuum process FgForrest/evitaDB
1 participant
@novoj