Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when querying non-existent entity by unique attribute #579

Closed
novoj opened this issue May 29, 2024 · 1 comment · Fixed by #580
Closed

Exception when querying non-existent entity by unique attribute #579

novoj opened this issue May 29, 2024 · 1 comment · Fixed by #580
Assignees
@novoj
Labels
bug Something isn't working
Milestone
Beta

Comments

@novoj
Copy link
Collaborator

novoj commented May 29, 2024

When we query entity by unique attribute like URL and this entity is not found. We get:

app//io.evitadb.api.exception.EntityCollectionRequiredException.<init>(EntityCollectionRequiredException.java:46)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula.lambda$computeInternal$0(EntityFilteringFormula.java:89)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula$$Lambda$2115/0x0000000801594698.get(Unknown Source)
app//io.evitadb.utils.Assert.isTrue(Assert.java:135)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula.computeInternal(EntityFilteringFormula.java:87)
@novoj novoj added the bug Something isn't working label May 29, 2024
@novoj novoj added this to the Beta milestone May 29, 2024
@novoj novoj self-assigned this May 29, 2024
@novoj
Copy link
Collaborator Author

novoj commented May 29, 2024

Unfortunately, it was not possible to write a test for this case because it required special composition of the query, data and also enabled observability facilities.

novoj added a commit that referenced this issue May 29, 2024
@novoj
fix(#579): Exception when querying non-existent entity by unique attr…
7cadd3c 
…ibute

When we query entity by unique attribute like URL and this entity is not found. We get:

```
app//io.evitadb.api.exception.EntityCollectionRequiredException.<init>(EntityCollectionRequiredException.java:46)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula.lambda$computeInternal$0(EntityFilteringFormula.java:89)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula$$Lambda$2115/0x0000000801594698.get(Unknown Source)
app//io.evitadb.utils.Assert.isTrue(Assert.java:135)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula.computeInternal(EntityFilteringFormula.java:87)
```

Unfortunately, it was not possible to write a test for this case because it required special composition of the query, data and also enabled observability facilities.
novoj added a commit that referenced this issue May 29, 2024
@novoj
fix(#579): Exception when querying non-existent entity by unique attr…
13d726f 
…ibute

When we query entity by unique attribute like URL and this entity is not found. We get:

```
app//io.evitadb.api.exception.EntityCollectionRequiredException.<init>(EntityCollectionRequiredException.java:46)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula.lambda$computeInternal$0(EntityFilteringFormula.java:89)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula$$Lambda$2115/0x0000000801594698.get(Unknown Source)
app//io.evitadb.utils.Assert.isTrue(Assert.java:135)
app//io.evitadb.core.query.algebra.prefetch.EntityFilteringFormula.computeInternal(EntityFilteringFormula.java:87)
```

Unfortunately, it was not possible to write a test for this case because it required special composition of the query, data and also enabled observability facilities.
@novoj novoj linked a pull request May 29, 2024 that will close this issue
fix(#579): Exception when querying non-existent entity by unique attribute #580
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novoj novoj

Labels
bug Something isn't working
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

fix(#579): Exception when querying non-existent entity by unique attribute FgForrest/evitaDB
1 participant
@novoj