Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid certificate generation when no TLS endpoint is configured #588

Closed
novoj opened this issue May 30, 2024 · 0 comments · Fixed by #589
Closed

Avoid certificate generation when no TLS endpoint is configured #588

novoj opened this issue May 30, 2024 · 0 comments · Fixed by #589
Assignees
@novoj
Labels
bug Something isn't working
Milestone
Beta

Comments

@novoj
Copy link
Collaborator

novoj commented May 30, 2024

Currently server generates or requires access to the certificates even if there is no TLS configured on any endpoint. Also we shouldn't generate and provide client certificates if MTLs is not configured.
@novoj novoj added the bug Something isn't working label May 30, 2024
@novoj novoj added this to the Beta milestone May 30, 2024
@novoj novoj self-assigned this May 30, 2024
novoj added a commit that referenced this issue May 30, 2024
@novoj
fix(#588): Avoid certificate generation when no TLS endpoint is confi…
8c31e2d 
…gured

Currently server generates or requires access to the certificates even if there is no TLS configured on any endpoint. Also we shouldn't generate and provide client certificates if MTLs is not configured.

Also this patch changes how gRPC readiness probe works. Now Managed channel is used.
@novoj novoj linked a pull request May 30, 2024 that will close this issue
fix(#588): Avoid certificate generation when no TLS endpoint is confi… #589
Merged
novoj added a commit that referenced this issue May 30, 2024
@novoj
Merge pull request #589 from FgForrest/588-avoid-certificate-generati…
effa84e 
…on-when-no-tls-endpoint-is-configured

fix(#588): Avoid certificate generation when no TLS endpoint is confi…
novoj added a commit that referenced this issue May 30, 2024
@novoj
fix(#588): Avoid certificate generation when no TLS endpoint is confi…
7ffed91 
…gured

Currently server generates or requires access to the certificates even if there is no TLS configured on any endpoint. Also we shouldn't generate and provide client certificates if MTLs is not configured.

Also this patch changes how gRPC readiness probe works. Now Managed channel is used.
novoj added a commit that referenced this issue Jun 7, 2024
@novoj
fix(#588): Avoid certificate generation when no TLS endpoint is confi…
2decec4 
…gured

Currently server generates or requires access to the certificates even if there is no TLS configured on any endpoint. Also we shouldn't generate and provide client certificates if MTLs is not configured.

Also this patch changes how gRPC readiness probe works. Now Managed channel is used.

(cherry picked from commit 8c31e2d)
novoj added a commit that referenced this issue Jun 7, 2024
@novoj
fix(#588): Avoid certificate generation when no TLS endpoint is confi…
0d0f33c 
…gured

Currently server generates or requires access to the certificates even if there is no TLS configured on any endpoint. Also we shouldn't generate and provide client certificates if MTLs is not configured.

Also this patch changes how gRPC readiness probe works. Now Managed channel is used.

(cherry picked from commit 7ffed91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@novoj novoj

Labels
bug Something isn't working
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

fix(#588): Avoid certificate generation when no TLS endpoint is confi… FgForrest/evitaDB
1 participant
@novoj