Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Clicking a links in an event descriptions doesn't open the link #7

Open
simonexmachina opened this issue Feb 27, 2020 · 2 comments
Open

Comments

@simonexmachina
Copy link

Nor can I right-click to copy the URL.

@mmoustafa
Copy link

mmoustafa commented Apr 4, 2020

This is because links in the event descriptions have a target="_blank" but do NOT include the rel attribute with rel="noopener noreferrer". So the URL for the electron new-window event is effectively about:blank.

You can test this by adding wc.openDevTools() to main.js and adding the rel attribute through dev tools, then clicking the link.

A proposed solution is to automatically run wc.executeJavaScript("document.querySelectorAll('a[target=_blank]').forEach(node => node.setAttribute('rel', 'noopener noreferrer'))") on DOM change.

@simonexmachina
Copy link
Author

Any updates on this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants