Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details not working and layer config error #4002

Closed
Tracked by #66
jolevesq opened this issue Sep 27, 2021 · 8 comments
Closed
Tracked by #66

Details not working and layer config error #4002

jolevesq opened this issue Sep 27, 2021 · 8 comments

Comments

@jolevesq
Copy link
Contributor

jolevesq commented Sep 27, 2021

When we load this layer (000183ed-8864-42f0-ae43-c4313a860720 - "https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/900A_and_top_100_en/MapServer") in 3.3.3 everything works well. When we load it in 3.3.4 from loadbyUUID, from keys parameter or the plus sign there is an error in the console

    at rv-main.js:1243

At the same time, details is not working for this layer.

@jolevesq jolevesq added bug-type: confusing bug-type: regression for: FGP For issues that are in support of the Federal Geospatial Platform problem: bug labels Sep 27, 2021
@jolevesq jolevesq changed the title Details not working andlayer config error Details not working and layer config error Sep 29, 2021
@james-rae
Copy link
Member

I don't have access to your RCS (or RCS-like) service, can you provide details on how you are loading the layer? Specifically, which sublayers, and if it's feature or dynamic layer.

I've tried a couple of loads via the + wizard and things seem to work so need some specifics.

@jolevesq jolevesq moved this from Follow Up to Under Analysis in FGP Visualization Requirements (Redmine) Nov 2, 2021
@jolevesq jolevesq moved this from Not Viewer Related to Not Able to Reproduce in FGP Visualization Requirements (Redmine) Nov 2, 2021
@jolevesq
Copy link
Contributor Author

@james-rae Hi, can you test this by going to https://osdp-psdo.canada.ca/dp/en/explore then in the search input below the map type 900A. On the second record, click add to map.

Then if you look at the console there is a layer config error and the detail panel is not working anymore. We have theh same behavior on OpenMaps(https://search.open.canada.ca/openmap/000183ed-8864-42f0-ae43-c4313a860720) and GcGeo(https://gcgeo.gc.ca/viz/index-en.html?keys=000183ed-8864-42f0-ae43-c4313a860720)

The RCS return value:

[
    {
        "layers": [
            {
                "layerType": "esriDynamic",
                "service_url": "https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/900A_and_top_100_en/MapServer",
                "name": "Mineral Areas, Producing Mines, and Oil and Gas Fields (900A)",
                "id": "rcs.000183ed-8864-42f0-ae43-c4313a860720.en",
                "url": "https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/900A_and_top_100_en/MapServer",
                "layerEntries": [
                    {
                        "index": 1
                    }
                ]
            }
        ]
    }
]

@james-rae
Copy link
Member

james-rae commented Nov 24, 2021

Thanks that helps considerably.

Findings: Looks like problem is because the index is a layer group, not leaf layer. I suspect the fix to stateOnly sublayers in the last release is what caused the change ( #3908 ). I do see the identify not working (by clicking the map), however the details via the grid works. Would suggest first looking at the legend load and how it's handling the sublayers (search for code const config = entry.proxyWrapper.layerConfig;), and after that I would hope the identify is resolved, if not inspect the identify pipeline.

Way for dev team to reproduce:

  • Load up sample index-fgp-en.html
  • + wizard, add layer url https://maps-cartes.services.geo.ca/server_serveur/rest/services/NRCan/900A_and_top_100_en/MapServer
  • Pick Dynamic Layer
  • Pick sublayer 900A, which is top of a big group
  • Add layer and watch the fireworks.

@jolevesq
Copy link
Contributor Author

@james-rae Yeah, when we add from the wizard it works. Is it a fix that should be made inside the RAMP itself?

@dan-bowerman
Copy link
Member

@jolevesq We will look into it, it does seem to be a problem with RAMP itself and a fix will be pursued.

@james-rae I wonder if this is the same bug preventing identify from working properly in this sample?: https://maps-cartes.dev.ec.gc.ca/sandbox/ramp-website/index.html#/samples/sample_context (ECCC VPN required)

@james-rae
Copy link
Member

@dan-bowerman Yep, same error location, same configuration scenario. Very good odds a fix here will clear that site up as well 🎲

@jolevesq
Copy link
Contributor Author

@dan-bowerman @james-rae we are experiencing a lot of weird stuff at the moment. I think most of them are server related but if you are able to find the exact cause and a solution it would be great so we can remove one variable of our bug fixing. Thanks.

@jolevesq
Copy link
Contributor Author

jolevesq commented Dec 8, 2021

@dan-bowerman Hi, I see code has been merge related too this issue. Do you know when it will be available as a release?

FGP Visualization Requirements (Redmine) automation moved this from Not Able to Reproduce to Done Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants