Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP URL trickery #4087

Closed
james-rae opened this issue Jan 12, 2023 · 1 comment
Closed

Remove HTTP URL trickery #4087

james-rae opened this issue Jan 12, 2023 · 1 comment
Assignees
Labels
addition: change request priority: low type: adaptive Adaptive maintenance. Changes to environment/standards

Comments

@james-rae
Copy link
Member

Parts of the RAMP core will generate certain URLs using the protocol that the host site is in. In particular, the URL to the ESRI JS API and the ESPG projection lookup service (if no urls are supplied in the config, which is typical case).

Since http is now becoming less common, and CORS is more common, we are finding this url logic can cause CORS errors when attempting to access the http version of those services. Most notably when attempting to run RAMP in develoment mode using localhost. We could probably config our rush scripts to serve via https but this could also happen in any http host sites, as well it would not be shocking if those two services depreciated their http endpoints.

Remove the trickery. Always use the https version of those URLs.

  • epsg.feature.ts
  • config.service.js
  • global.registry.js (not used but clean it up anyways).

Note there is also some stuff in loader-service.directive.js, but I think we should leave this as is, since the affected URL is user supplied and http may be valid in niche scenarios.

@james-rae james-rae added priority: low addition: change request type: adaptive Adaptive maintenance. Changes to environment/standards labels Jan 12, 2023
@prosperva
Copy link

I support this one @james-rae. I have had to create a localhost certificate to solve CORS issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition: change request priority: low type: adaptive Adaptive maintenance. Changes to environment/standards
Projects
None yet
Development

No branches or pull requests

2 participants