Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinate Info Plugin geomag calculation #90

Closed
jolevesq opened this issue May 8, 2019 · 3 comments
Closed

Coordinate Info Plugin geomag calculation #90

jolevesq opened this issue May 8, 2019 · 3 comments

Comments

@jolevesq
Copy link

jolevesq commented May 8, 2019

The geomagnetic calculation is now https

https://geomag.nrcan.gc.ca/service/tools/magnetic/calculator/?&callback=jQuery33109880967166820425_1533915134123&latitude=52.50606969511178&longitude=-99.27152207689319&date=2018-08-10&format=json

We can now remove the if to check if the viewer is http inside the index.ts file.

// Magnetic declination service is only available in http
        if (window.location.protocol === 'http:') {

@mweech Do you want us to create plugins issue inside plugins repo?

@james-rae
Copy link
Member

Great.

I'd vote to keep all issues in the one spot (so we don't need to be checking multiple lists). Though I can be overruled :'D

@mweech mweech transferred this issue from fgpv-vpgf/fgpv-vpgf May 10, 2019
@mweech
Copy link
Member

mweech commented May 10, 2019

Overruled!

@mpath
Copy link

mpath commented Aug 22, 2019

Tested in build: V3.1.0-b8
Issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants