Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading application.scss under the node_modules directory? #88

Closed
ruedap opened this issue Jun 6, 2018 · 1 comment
Closed

Reading application.scss under the node_modules directory? #88

ruedap opened this issue Jun 6, 2018 · 1 comment

Comments

@ruedap
Copy link

ruedap commented Jun 6, 2018

I have a problem with Sass::SyntaxError in LetterOpenerWeb::Letters#index occurs.

Environment

  • ruby 2.5.0p0
  • rails 5.2.0
  • letter_opener_web 1.3.4

Steps to reproduce the problem

# With letter_opener_web working properly

$ mkdir -p node_modules/foobar
$ touch node_modules/foobar/application.scss
$ echo ".foo { top: \$bar; }" > node_modules/foobar/application.scss
$ open http://localhost:3000/letter_opener

# An error occurs

Error

image

Is this a bug?
Why are you reading application.scss under the node_modules directory?

Thanks 😃

@ruedap
Copy link
Author

ruedap commented Jun 6, 2018

I was wrong. This behavior seems to be the default from Rails 5.1. 😇
https://github.com/rails/rails/pull/26836/files#diff-d5d2957cdc17a0b428be60e72e8dacd8R10

@ruedap ruedap closed this as completed Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant