Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview link dynamically in view mode #50

Open
steam3d opened this issue Oct 20, 2022 · 1 comment
Open

Add preview link dynamically in view mode #50

steam3d opened this issue Oct 20, 2022 · 1 comment

Comments

@steam3d
Copy link

steam3d commented Oct 20, 2022

Hi. Much better when URL automatically converted to iframe when you enable VIewMode like this plugin does:
https://github.com/samwarnick/obsidian-simple-embeds

@FHachez
Copy link
Owner

FHachez commented Feb 27, 2023

That sounds like a great idea. I like it, it's a different approach.

@steam3d I'm not convinced this plugin should start doing the same thing as obsidian-simple-embed. I don't think the need are the same. If you don't need to resize/interact with the embed, then obsidian-simple-embed is likely a better solution.
Maybe obsidian-simple-embed can also leverage the https://www.npmjs.com/package/@extractus/oembed-extractor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants