Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item data #3

Open
Trantarius opened this issue Dec 3, 2022 · 0 comments
Open

Item data #3

Trantarius opened this issue Dec 3, 2022 · 0 comments

Comments

@Trantarius
Copy link
Collaborator

We will need a source of data for item stats. Data dragon has too much missing or incorrect data to be used as a trusted source. A possible alternative is Community Dragon (https://www.communitydragon.org/) or data scraped from the wiki (https://leagueoflegends.fandom.com/wiki/Item_(League_of_Legends)).

The web-scraped data @fhill2 retrieved (https://github.com/fhill2/legends-docs/blob/main/upload/freddie/webscrape/items.json) includes some items that are no longer in the game as Pablo mentioned. The wiki has a "removed content" tag on these items, and they are found in a separate category of the items page, which may help remove them automatically. "Lethality" seems to be under the wrong key (e.g. on "Axiom Arc"), though this can be post-processed easily. There are a few other issues apparent on the removed items, but if they are being removed anyway it's not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant